Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopehoisting contributor documentation #8402

Merged
merged 16 commits into from
Aug 11, 2023
Merged

Scopehoisting contributor documentation #8402

merged 16 commits into from
Aug 11, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Aug 17, 2022 •
edited
Loading

  • the new per-symbol codesplitting feature

@parcel-benchmark
Copy link

parcel-benchmark commented Aug 17, 2022 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.45s -20.00ms
Cached 285.00ms +20.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.8692583b.js 1.48kb +0.00b 332.00ms -20.00ms 🚀
dist/legacy/index.a2819fc3.js 1.06kb +0.00b 332.00ms -20.00ms 🚀
dist/modern/index.2cb8781a.js 1.02kb +0.00b 332.00ms -20.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 252.00ms +18.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 251.00ms +17.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 4.15s +51.00ms
Cached 380.00ms -25.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 460.80kb +0.00b 1.07s +56.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 346.00ms +45.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 460.80kb +0.00b 1.00s -56.00ms 🚀
dist/PermalinkedComment.b41e2791.js 4.07kb +0.00b 371.00ms +34.00ms ⚠️
dist/UserProfile.2a2fa310.js 1.51kb +0.00b 370.00ms +33.00ms ⚠️
dist/NotFound.13a965e5.js 399.00b +0.00b 370.00ms +33.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 306.00ms +36.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 37.19s -807.00ms
Cached 2.18s +18.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.ca7cdd59.js 3.79mb +0.00b 17.00s -1.04s 🚀
dist/pdfRenderer.488477b0.js 1.11mb +0.00b 12.70s -883.00ms 🚀
dist/editorView.35ac73e7.js 619.90kb +0.00b 13.93s -1.02s 🚀
dist/media-viewer.6b8adda1.js 537.45kb +0.00b 8.46s -711.00ms 🚀
dist/ConfigPanelFieldsLoader.54b2cecc.js 306.94kb +0.00b 8.47s -715.00ms 🚀
dist/card.583a1f18.js 140.31kb +0.00b 8.46s -710.00ms 🚀
dist/ElementBrowser.8e866a0e.js 62.33kb +0.00b 8.46s -715.00ms 🚀
dist/archive.a2217524.js 60.29kb +0.00b 11.99s +2.82s ⚠️
dist/esm.1a044825.js 59.85kb +0.00b 8.46s -710.00ms 🚀
dist/component-lazy.1b33c14d.js 59.63kb +0.00b 6.05s -377.00ms 🚀
dist/DatePicker.9c23032b.js 47.98kb +0.00b 6.05s -381.00ms 🚀
dist/DatePicker.a3ad9fca.js 25.15kb +0.00b 6.05s -381.00ms 🚀
dist/ConfigPanelFieldsLoader.3cdf42ed.js 15.95kb +0.00b 8.46s -715.00ms 🚀
dist/ui.f919792f.js 14.62kb +0.00b 8.46s -716.00ms 🚀
dist/ConfigPanelFieldsLoader.0c1e88b7.js 13.78kb +0.00b 8.46s -716.00ms 🚀
dist/pdfRenderer.187ba54d.js 12.21kb +0.00b 8.46s -710.00ms 🚀
dist/mobile-upload.41e1ddfc.js 7.99kb +0.00b 8.46s -715.00ms 🚀
dist/mobile-upload.f2b8a53f.js 7.99kb +0.00b 8.46s -716.00ms 🚀
dist/media-viewer-analytics-error-boundary.c1511b0d.js 3.32kb +0.00b 11.99s +2.82s ⚠️
dist/ru.896915b9.js 2.94kb +0.00b 8.46s +2.03s ⚠️
dist/uk.48c97550.js 2.89kb +0.00b 8.46s -703.00ms 🚀
dist/codeViewerRenderer.f99075be.js 2.74kb +0.00b 11.99s +2.82s ⚠️
dist/th.31044730.js 2.73kb +0.00b 8.46s -703.00ms 🚀
dist/ResourcedEmojiComponent.1ec35575.js 2.60kb +0.00b 6.05s -382.00ms 🚀
dist/pl.5f36d63e.js 2.38kb +0.00b 6.05s -383.00ms 🚀
dist/cs.971d1d60.js 2.36kb +0.00b 6.05s -381.00ms 🚀
dist/de.6efbb375.js 2.30kb +0.00b 6.05s -382.00ms 🚀
dist/fr.af2c92ae.js 2.25kb +0.00b 6.05s -382.00ms 🚀
dist/es.23f0c164.js 2.25kb +0.00b 6.05s -382.00ms 🚀
dist/hu.8323f36b.js 2.23kb +0.00b 6.05s -382.00ms 🚀
dist/fi.7ed4b1b5.js 2.22kb +0.00b 6.05s -382.00ms 🚀
dist/ja.5653161c.js 2.22kb +0.00b 6.05s -382.00ms 🚀
dist/vi.d8dcb67a.js 2.22kb +0.00b 8.46s -703.00ms 🚀
dist/pt_BR.eccfad73.js 2.19kb +0.00b 6.05s -382.00ms 🚀
dist/tr.46f26598.js 2.16kb +0.00b 8.46s -703.00ms 🚀
dist/ko.2cf2bbda.js 2.11kb +0.00b 6.05s -382.00ms 🚀
dist/sv.13d93533.js 2.10kb +0.00b 8.46s -703.00ms 🚀
dist/it.601d375a.js 2.10kb +0.00b 6.05s -381.00ms 🚀
dist/nb.b300dd3e.js 2.09kb +0.00b 6.05s -383.00ms 🚀
dist/date.7b2f9581.js 2.07kb +0.00b 5.48s -301.00ms 🚀
dist/da.21385cf2.js 2.07kb +0.00b 6.05s -382.00ms 🚀
dist/nl.3999ea58.js 2.07kb +0.00b 6.05s -383.00ms 🚀
dist/images.46c877f3.js 2.03kb +0.00b 5.48s -301.00ms 🚀
dist/zh_TW.afaf6222.js 1.98kb +0.00b 8.46s -703.00ms 🚀
dist/zh.fcdc32bb.js 1.96kb +0.00b 8.46s -715.00ms 🚀
dist/feedback.fd1f6260.js 1.89kb +0.00b 6.05s -382.00ms 🚀
dist/status.6f638b3d.js 1.80kb +0.00b 5.48s -300.00ms 🚀
dist/code.ef3dfa9c.js 1.69kb +0.00b 5.48s -301.00ms 🚀
dist/workerHasher.4b89e1de.js 1.69kb +0.00b 8.46s -715.00ms 🚀
dist/workerHasher.06536d4e.js 1.69kb +0.00b 8.46s -715.00ms 🚀
dist/list-number.35bc7f17.js 1.60kb +0.00b 5.48s -300.00ms 🚀
dist/heading6.974f167d.js 1.49kb +0.00b 6.05s -382.00ms 🚀
dist/link.542e87bf.js 1.41kb +0.00b 5.48s -300.00ms 🚀
dist/emoji.79757e2c.js 1.38kb +0.00b 5.48s -301.00ms 🚀
dist/expand.801fc3a0.js 1.31kb +0.00b 6.05s -382.00ms 🚀
dist/mention.adafe481.js 1.21kb +0.00b 5.48s -301.00ms 🚀
dist/layout.40f6b132.js 1.17kb +0.00b 5.48s -300.00ms 🚀
dist/divider.616b37d8.js 1.17kb +0.00b 5.48s -301.00ms 🚀
dist/action.361730a6.js 1.15kb +0.00b 5.48s -301.00ms 🚀
dist/heading1.495af5dc.js 1.14kb +0.00b 5.48s -300.00ms 🚀
dist/list.c5ad55b6.js 1.11kb +0.00b 5.48s -301.00ms 🚀
dist/quote.235ab420.js 1.11kb +0.00b 5.48s -301.00ms 🚀
dist/decision.36a0b771.js 1.10kb +0.00b 5.48s -301.00ms 🚀
dist/panel-warning.7e72ad42.js 1.07kb +0.00b 5.48s -301.00ms 🚀
dist/16.0d8c3c9e.js 1.06kb +0.00b 5.48s -300.00ms 🚀
dist/table.389f0908.js 1.05kb +0.00b 5.48s -300.00ms 🚀
dist/panel.7cee1972.js 1017.00b +0.00b 5.48s -301.00ms 🚀
dist/panel-error.e46252ff.js 994.00b +0.00b 5.48s -301.00ms 🚀
dist/16.dcf139e7.js 951.00b +0.00b 5.48s -301.00ms 🚀
dist/panel-success.dbd2515b.js 935.00b +0.00b 5.48s -301.00ms 🚀
dist/panel-note.b6c94ff5.js 925.00b +0.00b 5.48s -301.00ms 🚀
dist/16.f6395317.js 876.00b +0.00b 5.48s -301.00ms 🚀
dist/pt_PT.402f9c4e.js 765.00b +0.00b 6.05s -382.00ms 🚀
dist/et.69382942.js 763.00b +0.00b 6.05s -382.00ms 🚀
dist/simpleHasher.8b7def87.js 719.00b +0.00b 8.46s -715.00ms 🚀
dist/simpleHasher.38195df7.js 719.00b +0.00b 8.46s -716.00ms 🚀
dist/is.5b945719.js 625.00b +0.00b 6.05s -382.00ms 🚀
dist/ro.a6eff34a.js 612.00b +0.00b 8.46s +2.03s ⚠️
dist/en_GB.61f7112a.js 602.00b +0.00b 6.05s -382.00ms 🚀
dist/en.41261459.js 599.00b +0.00b 6.05s -382.00ms 🚀
dist/index.html 248.00b +0.00b 12.17s +6.82s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/refractor.c460668c.js 601.81kb +0.00b 11.50s -802.00ms 🚀
dist/media-viewer.6b8adda1.js 537.45kb +0.00b 11.50s +2.39s ⚠️
dist/popup.c282bed0.js 324.59kb +0.00b 11.50s -801.00ms 🚀
dist/ConfigPanelFieldsLoader.54b2cecc.js 306.94kb +0.00b 8.30s -809.00ms 🚀
dist/EmojiPickerComponent.1a5571cb.js 189.81kb +0.00b 11.49s -812.00ms 🚀
dist/card.583a1f18.js 140.31kb +0.00b 8.30s -808.00ms 🚀
dist/ConfigPanelFieldsLoader.d25d4efc.js 83.10kb +0.00b 11.49s -794.00ms 🚀
dist/esm.1c9ef78b.js 63.49kb +0.00b 11.50s -801.00ms 🚀
dist/ElementBrowser.8e866a0e.js 62.33kb +0.00b 8.30s -808.00ms 🚀
dist/archive.a2217524.js 60.29kb +0.00b 11.50s +2.39s ⚠️
dist/esm.1a044825.js 59.85kb +0.00b 8.30s -808.00ms 🚀
dist/component-lazy.1b33c14d.js 59.63kb +0.00b 6.22s +550.00ms ⚠️
dist/esm.3fa8c7de.js 39.56kb +0.00b 11.50s -800.00ms 🚀
dist/smartMediaEditor.0fdaaac3.js 21.89kb +0.00b 11.50s -802.00ms 🚀
dist/esm.699bbabf.js 20.65kb +0.00b 11.50s -800.00ms 🚀
dist/ConfigPanelFieldsLoader.3cdf42ed.js 15.95kb +0.00b 8.30s -808.00ms 🚀
dist/ui.f919792f.js 14.62kb +0.00b 8.30s -808.00ms 🚀
dist/ConfigPanelFieldsLoader.0c1e88b7.js 13.78kb +0.00b 8.30s -809.00ms 🚀
dist/dropzone.7e088531.js 13.61kb +0.00b 11.50s -801.00ms 🚀
dist/pdfRenderer.187ba54d.js 12.21kb +0.00b 8.30s -808.00ms 🚀
dist/dropzone.09d0b890.js 11.64kb +0.00b 11.50s -801.00ms 🚀
dist/Toolbar.7b6f497e.js 9.53kb +0.00b 11.50s -802.00ms 🚀
dist/clipboard.f5f3497c.js 8.07kb +0.00b 11.50s -801.00ms 🚀
dist/mobile-upload.41e1ddfc.js 7.99kb +0.00b 8.30s -809.00ms 🚀
dist/mobile-upload.f2b8a53f.js 7.99kb +0.00b 8.30s -809.00ms 🚀
dist/mobile-upload.40a8f0fb.js 7.99kb +0.00b 11.50s -800.00ms 🚀
dist/index.runtime.50c92a63.js 7.42kb +0.00b 11.50s -802.00ms 🚀
dist/browser.333a8efe.js 7.33kb +0.00b 11.50s -801.00ms 🚀
dist/index.b16227d6.css 4.08kb +0.00b 11.52s -796.00ms 🚀
dist/media-viewer-analytics-error-boundary.c1511b0d.js 3.32kb +0.00b 11.50s +2.39s ⚠️
dist/media-picker-analytics-error-boundary.418c2c46.js 3.32kb +0.00b 11.50s -800.00ms 🚀
dist/media-card-analytics-error-boundary.7d513b72.js 3.32kb +0.00b 11.50s -801.00ms 🚀
dist/ru.896915b9.js 2.94kb +0.00b 8.30s +1.91s ⚠️
dist/uk.48c97550.js 2.89kb +0.00b 8.30s -807.00ms 🚀
dist/codeViewerRenderer.f99075be.js 2.74kb +0.00b 8.30s -809.00ms 🚀
dist/th.31044730.js 2.73kb +0.00b 8.30s -807.00ms 🚀
dist/vi.d8dcb67a.js 2.22kb +0.00b 8.30s -807.00ms 🚀
dist/tr.46f26598.js 2.16kb +0.00b 8.30s -807.00ms 🚀
dist/sv.13d93533.js 2.10kb +0.00b 8.30s -807.00ms 🚀
dist/zh_TW.afaf6222.js 1.98kb +0.00b 8.30s -807.00ms 🚀
dist/zh.fcdc32bb.js 1.96kb +0.00b 8.30s -808.00ms 🚀
dist/workerHasher.4b89e1de.js 1.69kb +0.00b 8.30s -808.00ms 🚀
dist/workerHasher.06536d4e.js 1.69kb +0.00b 8.30s -809.00ms 🚀
dist/workerHasher.dd4d2a38.js 1.69kb +0.00b 11.50s -801.00ms 🚀
dist/workerHasher.eae92e5c.js 1.69kb +0.00b 11.50s -800.00ms 🚀
dist/workerHasher.cfe5994f.js 1.69kb +0.00b 11.50s -800.00ms 🚀
dist/sk.101f1705.js 786.00b +0.00b 8.30s -807.00ms 🚀
dist/simpleHasher.8b7def87.js 719.00b +0.00b 8.30s -809.00ms 🚀
dist/simpleHasher.38195df7.js 719.00b +0.00b 8.30s -809.00ms 🚀
dist/simpleHasher.308c3a38.js 719.00b +0.00b 11.50s -801.00ms 🚀
dist/simpleHasher.f29b9a84.js 719.00b +0.00b 11.50s -800.00ms 🚀
dist/simpleHasher.d2c7eaf0.js 719.00b +0.00b 11.50s -800.00ms 🚀
dist/ro.a6eff34a.js 612.00b +0.00b 8.30s +1.91s ⚠️
dist/index.html 248.00b +0.00b 7.87s +2.20s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 3.00s -106.00ms
Cached 320.00ms +14.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic marked this pull request as ready for review March 27, 2023 17:20
@mischnic mischnic merged commit b6224fd into v2 Aug 11, 2023
16 checks passed
@mischnic mischnic deleted the scopehoisting-docs branch August 11, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebriando thebriando thebriando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @parcel-benchmark @thebriando